-
Notifications
You must be signed in to change notification settings - Fork 16
WIP: Dynamic OG complex field #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ab243f1
Dynamic OG complex field 101.
2dc6d51
Cool!
d936cc6
Improve API.
36b4bbf
Order code.
f41c065
commit work.
9f57bb8
More code order.
12d9d26
Handle autocomplete tags.
c6c1a8f
Order code.
9e7a24c
Remove a lot(!!!) of code.
5f58a88
Improve.
4661857
check another instance.
c15ed4a
Working on the other groups widgets.
722dcc0
Basic widget are working.
8625a13
Trying something.
a947498
Display the groups in options and select element. Start working on au…
83a6ae2
Filter the other groups.
3fe2043
Fix the handlers. Need to do - autocomplete.
77c47bf
Handler working in a specific stage.
0854b3f
Commit current work - start build a custom multiple autocomplete.
e4a241e
Push work on the custom auto complete handler.
0a1ab76
Start working on the add another button.
ce94367
Push a minor fix.
5b7c4dc
Fix conflixts
8d0eac6
When installing set default mode for the fields.
095998d
Default handlers.
f03623c
The target type need to be set not matter what.
748a921
Stabilise?
2755dc3
Going back to base.
010efa8
Minor push.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for splitting this off as static methods in OgGroupAudienceHelper? Are you planning on reusing them somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - we would like to get all the available widget so the user could pick them through the UI. No?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way to go! That's the spirit!