WIP: Dynamic OG complex field#161
Conversation
|
@amitaibu I think i'm on to something here: |
|
Oh boy, looks like this will invalidate all my work on OgComplexWidgetTest :) Never mind, this looks like a great improvement! |
|
👍 |
|
I was pretty amazed to get to this point. I think the multiple autocomplete widget is the bad boy in this story since we need to wrap it with add another item but i'll handle it. |
|
I made another improvement to the API. Some minor documentation: dpm(OgGroupAudienceHelper::getAvailableWidgets());
OgGroupAudienceHelper::setWidgets('node', 'group_content', 'og_group_ref', [
'default' => 'options_select',
'admin' => 'options_select',
]); |
|
nice! now only to see if you can save and edit ;) |
|
This is actually not interfering at all with the OgComplexWidgetTest from #140, this is even answering some questions I had in there :) The relevant part is the |
|
@RoySegall OK if I work on the test part of this? I won't touch your code. |
|
I have a couple of things i'd like to do you could join in such as ordering the code. I'll ping you. |
|
I tried to do a couple of things but you can join in although I think it would be very confusing. |
|
OK no problem, I'm going to work on #162 today. |
|
Didn't got the time but all the default groups selection are working. We need to handle the other group. Also we need to handle views selection handler but we can keep for it later. |
| if ($handler instanceof EntityReferenceAutocompleteWidget) { | ||
| // No need for extra work here since we already extending the auto | ||
| // complete handler. | ||
| return $multiple; |
| } | ||
|
|
||
| return $widgets; | ||
| } |
There was a problem hiding this comment.
What's the reason for splitting this off as static methods in OgGroupAudienceHelper? Are you planning on reusing them somewhere else?
There was a problem hiding this comment.
Yes - we would like to get all the available widget so the user could pick them through the UI. No?
There was a problem hiding this comment.
Way to go! That's the spirit!
|
@RoySegall can you please give a quick update on what you accomplished yesterday. |
|
Yeah. Sure. The handlers give us the correct groups - my groups and other groups. There are still some WTF with the other group widget when it's set to autocomplete and when selecting groups via autocomplete the groups are being ignored - problem with FAPI and how the values are processed. Except that - we all set to go :) |
|
Update: I managed to have a single auto complete element and get his selected group. The next part will be to have a multiple one but I think that in this case we would to create our own 'Add another button' as we did at the beginning. I'll update. |
|
I pushed now a small work on the custom widget - https://gfycat.com/DisloyalRegularKodiakbear - looks good for now. |
|
@RoySegall what's the status on this one - what's left? |
|
I need to handle "Add another button" for the other groups widget. |
|
Closing infavor of #248. |
Prevent notice on create new content
3 participants
No description provided.