Skip to content

bench: fix 4-bit byte accounting in benchmark metrics #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pritiks23 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

bench: fix 4-bit byte accounting in benchmark metrics #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bench/include/bench_metrics.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ class BenchmarkMetrics
MatrixType c_type);

/**
* @brief Get size in bytes for a matrix type
* @brief Get bytes-per-element for a matrix type.
*/
static size_t getMatrixTypeSize(MatrixType type);
static double getMatrixTypeSize(MatrixType type);
};

} // namespace dlp::benchmarking
10 changes: 5 additions & 5 deletions bench/src/bench_metrics.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@

namespace dlp::benchmarking {

size_t
double
BenchmarkMetrics::getMatrixTypeSize(MatrixType type)
{
switch (type) {
case MatrixType::u4:
case MatrixType::s4:
return 1; // 4-bit types packed, but count as 1 byte min
return 0.5;
case MatrixType::u8:
case MatrixType::s8:
return 1;
Expand Down Expand Up @@ -73,9 +73,9 @@ BenchmarkMetrics::calculateAndReport(benchmark::State& state,

// For bandwidth calculation, we need bytes and will let Google Benchmark
// calculate the rate
size_t size_a = getMatrixTypeSize(a_type);
size_t size_b = getMatrixTypeSize(b_type);
size_t size_c = getMatrixTypeSize(c_type);
double size_a = getMatrixTypeSize(a_type);
double size_b = getMatrixTypeSize(b_type);
double size_c = getMatrixTypeSize(c_type);

double bytes_A = static_cast<double>(m) * k * size_a;
double bytes_B = static_cast<double>(k) * n * size_b;
Expand Down
22 changes: 11 additions & 11 deletions tests/bench/test_bench_utilities.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ namespace dlp::benchmarking {
class BenchmarkMetrics
{
public:
static size_t getMatrixTypeSize(MatrixType type);
static double getMatrixTypeSize(MatrixType type);
};
} // namespace dlp::benchmarking

Expand Down Expand Up @@ -303,52 +303,52 @@ class MatrixTypeSizeTest : public ::testing::Test

TEST_F(MatrixTypeSizeTest, U4TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::u4), 1);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::u4), 0.5);
}

TEST_F(MatrixTypeSizeTest, S4TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::s4), 1);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::s4), 0.5);
}

TEST_F(MatrixTypeSizeTest, U8TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::u8), 1);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::u8), 1.0);
}

TEST_F(MatrixTypeSizeTest, S8TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::s8), 1);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::s8), 1.0);
}

TEST_F(MatrixTypeSizeTest, U16TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::u16), 2);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::u16), 2.0);
}

TEST_F(MatrixTypeSizeTest, S16TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::s16), 2);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::s16), 2.0);
}

TEST_F(MatrixTypeSizeTest, BF16TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::bf16), 2);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::bf16), 2.0);
}

TEST_F(MatrixTypeSizeTest, U32TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::u32), 4);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::u32), 4.0);
}

TEST_F(MatrixTypeSizeTest, S32TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::s32), 4);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::s32), 4.0);
}

TEST_F(MatrixTypeSizeTest, F32TypeSize)
{
EXPECT_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::f32), 4);
EXPECT_DOUBLE_EQ(BenchmarkMetrics::getMatrixTypeSize(MatrixType::f32), 4.0);
}

// ============================================================================
Expand Down