bench: fix 4-bit byte accounting in benchmark metrics - #15
Open
Pritiks23 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Pritika Vipin <65793273+Pritiks23@users.noreply.github.com>
Pritiks23
commented
May 18, 2026
Pritiks23
left a comment
Contributor
Author
There was a problem hiding this comment.
Updated the benchmark metric logic so 4-bit matrix types are counted correctly in memory calculations.
What changed:
- In the benchmark metrics code, u4 and s4 are now treated as 0.5 bytes per element instead of 1 byte per element.
- The type-size helper now returns a floating-point value so it can represent half-byte element sizes.
- Benchmark utility tests were updated to match the new behavior (u4/s4 expected value changed from 1.0 to 0.5).
Why this change was needed:
- The previous logic overestimated memory traffic for 4-bit data by 2x.
- That made bandwidth and matrix-size metrics inaccurate for low-bit GEMM benchmarks.
- With this fix, reported benchmark metrics better reflect actual packed 4-bit storage, so performance analysis is more trustworthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
u4/s4 benchmark metrics are now accounted as 0.5 bytes per element, and related benchmark utility tests were updated accordingly.