Skip to content

stop subscription immediately even when there are pending retries #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faderskd wants to merge 2 commits into
base: master
Choose a base branch
from
Open

stop subscription immediately even when there are pending retries #1974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d745cf4
stop subscription immediately even when there are pending retries
faderskd Aug 18, 2025
b3e5a9c
Merge branch 'master' into stop-batch-subscription-immediately-in-cas…
szczygiel-m Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hermes-consumers/src/main/java/pl/allegro/tech/hermes/consumers/consumer/BatchConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,8 @@ && shouldRetryOnClientError(retryClientErrors, result))
.withStopStrategy(
attempt ->
attempt.getDelaySinceFirstAttempt() > messageTtlMillis
|| Thread.currentThread().isInterrupted())
|| Thread.currentThread().isInterrupted()
|| !consuming)
.withRetryListener(
getRetryListener(
result -> {
Expand Down
44 changes: 23 additions & 21 deletions ...rs/src/main/java/pl/allegro/tech/hermes/consumers/supervisor/process/ConsumerProcess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,7 @@ public void run() {
} finally {
logger.info("Releasing consumer process thread of subscription {}", getSubscriptionName());
refreshHealthcheck();
try {
stop();
} catch (Exception exceptionWhileStopping) {
logger.error(
"An error occurred while stopping consumer process of subscription {}",
getSubscriptionName(),
exceptionWhileStopping);
} finally {
onConsumerStopped.accept(getSubscriptionName());
Thread.currentThread().setName("consumer-released-thread");
}
stop();
}
}

Expand Down Expand Up @@ -119,7 +109,7 @@ private void process(Signal signal) {
"Stopping main loop for consumer {}. {}",

@michaldabrowski michaldabrowski Sep 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we'd like to to move this logger.info to the stop() method (or maybe we don't need it anymore as we have logger.info("Stopping consumer for subscription {}", getSubscriptionName()). It would be consistent with the other signal types logic.

signal.getTarget(),
signal.getLogWithIdAndType());
this.running = false;
stop();
break;
case RETRANSMIT:
retransmit(signal);
Expand Down Expand Up @@ -159,15 +149,27 @@ private void start(Signal signal) {
}

private void stop() {
long startTime = clock.millis();
logger.info("Stopping consumer for subscription {}", getSubscriptionName());

consumer.tearDown();

logger.info(
"Stopped consumer for subscription {} in {}ms",
getSubscriptionName(),
clock.millis() - startTime);
if (!running) {
return;
}
this.running = false;
try {
long startTime = clock.millis();
logger.info("Stopping consumer for subscription {}", getSubscriptionName());
consumer.tearDown();
logger.info(
"Stopped consumer for subscription {} in {}ms",
getSubscriptionName(),
clock.millis() - startTime);
} catch (Exception exceptionWhileStopping) {
logger.error(
"An error occurred while stopping consumer process of subscription {}",
getSubscriptionName(),
exceptionWhileStopping);
} finally {
onConsumerStopped.accept(getSubscriptionName());
Thread.currentThread().setName("consumer-released-thread");
}
}

private void retransmit(Signal signal) {
Expand Down
Loading