stop subscription immediately even when there are pending retries - #1974
Open
faderskd wants to merge 2 commits into
Open
stop subscription immediately even when there are pending retries#1974faderskd wants to merge 2 commits into
faderskd wants to merge 2 commits into
Conversation
faderskd
added
bug
hacktoberfest
hacktoberfest-accepted
and removed
hacktoberfest
hacktoberfest-accepted
labels
faderskd
marked this pull request as ready for review
August 19, 2025 10:31
faderskd
force-pushed
the
stop-batch-subscription-immediately-in-case-of-pending-messages
branch
from
August 19, 2025 15:25
983b3d8 to
97c8298
Compare
pitagoras3
approved these changes
Aug 20, 2025
pitagoras3
left a comment
pitagoras3
left a comment
Contributor
There was a problem hiding this comment.
Looks ok, nicely done
faderskd
force-pushed
the
stop-batch-subscription-immediately-in-case-of-pending-messages
branch
from
August 20, 2025 15:24
97c8298 to
d745cf4
Compare
michaldabrowski
approved these changes
Sep 23, 2025
| @@ -119,7 +109,7 @@ private void process(Signal signal) { | |||
| "Stopping main loop for consumer {}. {}", | |||
Contributor
There was a problem hiding this comment.
I wonder if we'd like to to move this logger.info to the stop() method (or maybe we don't need it anymore as we have logger.info("Stopping consumer for subscription {}", getSubscriptionName()). It would be consistent with the other signal types logic.
…e-of-pending-messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.