Skip to content

fix(test): align pomodoro-cycle default-duration assertion with current behavior #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(test): align pomodoro-cycle default-duration assertion with current behavior #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f591cb
Initial plan
Copilot Jul 2, 2026
9502385
fix(test): align pomodoro-cycle default time expectation
Copilot Jul 2, 2026
0429f1a
docs: align pomodoro-cycle default duration docs
Copilot Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ $ pomodoro-timer --from 09:30 60 # Resume timer that started at 09:30 for 60 m
**[`pomodoro-cycle`](./bin/pomodoro-cycle)** - Run a full multi-step Pomodoro cycle with breaks between sessions.

```bash
$ pomodoro-cycle # 3 steps × 30 min (default)
$ pomodoro-cycle # 3 steps × 25 min (default)
$ pomodoro-cycle 3 25 25 25 # Classic 3 × 25 min pomodoro
$ pomodoro-cycle 2 45 30 # step 1: 45 min, step 2: 30 min
```
Expand Down
6 changes: 3 additions & 3 deletions doc/bin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@ pomodoro-cycle [--ntfy] [steps [time1 [time2 [time3]]]]

**Arguments**:
- `steps` - Number of work steps in the cycle (default: `3`)
- `time1`, `time2`, `time3` - Duration of each step in minutes (default: `30`)
- `time1`, `time2`, `time3` - Duration of each step in minutes (default: `25`)

**Options**:
- `--ntfy` - Send ntfy notification when cycle finishes (in addition to desktop notification)
Expand All @@ -1104,9 +1104,9 @@ Runs a sequence of pomodoro work sessions. Between each step (except the last),

**Examples**:
```bash
# Run 3 steps of 30 minutes each (default)
# Run 3 steps of 25 minutes each (default)
$ pomodoro-cycle
Start pomodoro cycle: 3 steps with [30 30 30] minutes in each step
Start pomodoro cycle: 3 steps with [25 25 25] minutes in each step

> Starting 1-th work time
> 1 minutes / 30
Expand Down
4 changes: 2 additions & 2 deletions test/pomodoro-cycle.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ teardown() {

# --- Output header ---

@test '`pomodoro-cycle` should show 3 steps with 30 min each by default' {
@test '`pomodoro-cycle` should show 3 steps with 25 min each by default' {
run pomodoro-cycle
expects "$status" to_be 0
expects "${lines[0]}" to_match 'Start pomodoro cycle: 3 steps with \[30 30 30\] minutes in each step'
expects "${lines[0]}" to_match 'Start pomodoro cycle: 3 steps with \[25 25 25\] minutes in each step'
Comment thread
aiya000 marked this conversation as resolved.
}

@test '`pomodoro-cycle` should show custom step count in header' {
Expand Down
Loading