Open
fix(test): align pomodoro-cycle default-duration assertion with current behavior#78
Conversation
Copilot
AI
changed the title
[WIP] Fix failing test for pomodoro cycle
fix(test): align pomodoro-cycle default-duration assertion with current behavior
Jul 2, 2026
aiya000
marked this pull request as ready for review
July 2, 2026 04:00
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pomodoro-cycle Bats test suite so the default-duration header assertion matches the current bin/pomodoro-cycle behavior (defaulting each step to 25 minutes).
Changes:
- Updated the no-argument header expectation from
[30 30 30]to[25 25 25]. - Renamed the corresponding test description to reflect the 25-minute default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pomodoro-cycletest suite had one stale expectation: it assumed the default cycle duration was 30 minutes per step, while the command currently defaults to 25. This PR updates the test to match the implemented/defaulted behavior and accompanying help/docs.Issue summary
test/pomodoro-cycle.batsandbin/pomodoro-cycledefault step duration.Change made
30 30 30to25 25 25.Example (updated assertion)