Skip to content

fix(test): align pomodoro-cycle default-duration assertion with current behavior - #78

Open
aiya000 with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-pomodoro-cycle-test
Open

fix(test): align pomodoro-cycle default-duration assertion with current behavior#78
aiya000 with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-pomodoro-cycle-test

Conversation

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

pomodoro-cycle test suite had one stale expectation: it assumed the default cycle duration was 30 minutes per step, while the command currently defaults to 25. This PR updates the test to match the implemented/defaulted behavior and accompanying help/docs.

  • Issue summary

    • Corrected a mismatch between test/pomodoro-cycle.bats and bin/pomodoro-cycle default step duration.
  • Change made

    • Updated the default-header test case from 30 30 30 to 25 25 25.
    • Renamed the test description accordingly for consistency/readability.
  • Example (updated assertion)

    @test '`pomodoro-cycle` should show 3 steps with 25 min each by default' {
      run pomodoro-cycle
      expects "${lines[0]}" to_match 'Start pomodoro cycle: 3 steps with \[25 25 25\] minutes in each step'
    }

Copilot AI changed the title [WIP] Fix failing test for pomodoro cycle fix(test): align pomodoro-cycle default-duration assertion with current behavior Jul 2, 2026
Copilot AI requested a review from aiya000 July 2, 2026 03:54
@aiya000
aiya000 requested a review from Copilot July 2, 2026 04:00
@aiya000
aiya000 marked this pull request as ready for review July 2, 2026 04:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the pomodoro-cycle Bats test suite so the default-duration header assertion matches the current bin/pomodoro-cycle behavior (defaulting each step to 25 minutes).

Changes:

  • Updated the no-argument header expectation from [30 30 30] to [25 25 25].
  • Renamed the corresponding test description to reflect the 25-minute default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/pomodoro-cycle.bats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pomodoro-cycleのテストが落ちているので修正

3 participants