encrypt credential storage with platform-specific secure storage#360
Open
5a3b3f96-d11b-4a31-8373-09dd78df3e21 wants to merge 1 commit intoaimok04:mainfrom
Conversation
Author
|
Spit from a mega patch I was working on. Will need to test all PRs more rigorously individually tomorrow to ensure they work as separate units. |
Owner
|
Hi, This is definitely a good addition. You're totally right: credentials shouldn't be stored in plain text, I was a bit lazy there. I am going to take a look at it in the following days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves plaintext password storage