Skip to content

feat: add timeout setting under server advanced view#382

Open
jonsch318 wants to merge 4 commits intoaimok04:mainfrom
jonsch318:timeout-setting
Open

feat: add timeout setting under server advanced view#382
jonsch318 wants to merge 4 commits intoaimok04:mainfrom
jonsch318:timeout-setting

Conversation

@jonsch318
Copy link
Copy Markdown
Contributor

This implements a new server advanced settings view which currently only contains timeout options (long and short)

Resolves #359

It allows the TandoorClient to be reconfigured with different timeouts short & long.
I am not sure about the default short timeout chatgpt has given me 10seconds so idk

I had to modify SettingsServer a bit more than just adding the item to allow for nice Animation.
Technically the SettingsServerAdvanced view is not needed here, since the SettingsServer opens only the Content to the animations.

I tried with LLM to combine it into the main Settings Navigation with absolutely no luck and a terrible mess, so this it is i think.

@aimok04
Copy link
Copy Markdown
Owner

aimok04 commented Apr 18, 2026

@jonsch318

Looks good!

I applied some changes:

  • Added i18n for the labels in TimeoutSelectionBottomSheet (seconds was hard-coded)
  • Removed title from TimeoutSelectionBottomSheet. I don't really like using titles in these simple bottom sheets as they're mostly self-explanatory.
image image

I just think it looks cleaner this way.

I also removed the bottom padding from the LazyColumn in TimeoutSelectionBottomSheet - Was there a reason for it? I also think it looks cleaner without it.

@jonsch318
Copy link
Copy Markdown
Contributor Author

  1. Yep the seconds should have definitely been translated
  2. I agree looks better
  3. I don't think I had deep reasons to add the padding. With the title I still think it looks better, but without the title I don't care

@jonsch318
Copy link
Copy Markdown
Contributor Author

resolved conflicts with the version pr

@jonsch318
Copy link
Copy Markdown
Contributor Author

@aimok04 thanks for looking and adopting the PR's glad to help out more.
If you want you can asign me to ideas and issues you had aswell

Ps. before mine please take a look at #360 it may be more important 👀 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💡 Option to Increase timeout

2 participants