Skip to content

fix(api): address private network contract review #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitramir merged 1 commit into from
Jun 6, 2026
Merged

fix(api): address private network contract review #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proto/agynio/api/groups/v1/groups.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ message ListMemberGroupsRequest {
string member_id = 2;
int32 page_size = 3;
string page_token = 4;
string organization_id = 5;
}

message ListMemberGroupsResponse {
Expand Down
17 changes: 13 additions & 4 deletions proto/agynio/api/networks/v1/networks.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@ message PrivateResourceAccess {
string private_resource_id = 2;
PrivateResourceAccessPrincipalType principal_type = 3;
string principal_id = 4;
ProvisioningState provisioning_state = 5;
}

// Optional replacement for a port list in update requests.
message PortListUpdate {
// Numeric ports. Each value must be in the range 1..65535.
repeated int32 ports = 1;
}

message CreateNetworkRequest {
Expand Down Expand Up @@ -248,11 +255,13 @@ message UpdatePrivateResourceRequest {
optional string name = 2;
optional PrivateResourceProtocol protocol = 3;
optional string target_host = 4;
// Numeric target ports. Each value must be in the range 1..65535.
repeated int32 target_ports = 5;
// Deprecated: use target_ports_update to distinguish omitted from empty.
repeated int32 target_ports = 5 [deprecated = true];
optional string intercept_host = 6;
// Numeric intercept ports. Each value must be in the range 1..65535.
repeated int32 intercept_ports = 7;
// Deprecated: use intercept_ports_update to distinguish omitted from empty.
repeated int32 intercept_ports = 7 [deprecated = true];
optional PortListUpdate target_ports_update = 8;
optional PortListUpdate intercept_ports_update = 9;
}

message UpdatePrivateResourceResponse {
Expand Down
10 changes: 9 additions & 1 deletion proto/agynio/api/ziti_management/v1/ziti_management.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ message CreateRunnerIdentityRequest {
string runner_id = 1;
repeated string role_attributes = 2;
// Tags attached to the OpenZiti identity.
reserved 3, 4;
reserved "ziti_service_id", "ziti_service_name";
map<string, string> tags = 5;
}

Expand Down Expand Up @@ -492,7 +494,13 @@ message UpdateServiceRequest {
string ziti_service_id = 1;
optional HostV1Config host_v1_config = 2;
optional InterceptV1Config intercept_v1_config = 3;
map<string, string> tags = 4;
// Deprecated: use tags_update to distinguish omitted from empty.
map<string, string> tags = 4 [deprecated = true];
optional TagsUpdate tags_update = 5;
}

message TagsUpdate {
map<string, string> tags = 1;
}

message UpdateServiceResponse {
Expand Down
Loading