Skip to content

fix(api): address private network contract review#152

Merged
vitramir merged 1 commit into
mainfrom
noa/issue-151-contract-review
Jun 6, 2026
Merged

fix(api): address private network contract review#152
vitramir merged 1 commit into
mainfrom
noa/issue-151-contract-review

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • Add organization scoping to ListMemberGroupsRequest.
  • Add provisioning_state to PrivateResourceAccess.
  • Add presence-aware update wrappers for private resource ports and Ziti service tags while preserving existing fields as deprecated for compatibility.
  • Reserve the documented CreateRunnerIdentityRequest field-number gap.

Closes #151

Out of scope

Contract-only follow-up. No service implementation, Gateway handlers, DB migrations, NATS deployment, OpenFGA changes, or downstream generated client updates are included.

Test & Lint Summary

  • buf lint — passed with no errors.
  • buf breaking --against '.git#branch=origin/main' — passed with no breaking changes.
  • git diff --check — passed with no whitespace errors.

Test statistics: 3 passed / 0 failed / 0 skipped.
Linting passed with no errors.

@casey-brooks casey-brooks requested a review from a team as a code owner June 6, 2026 01:41
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf lint — passed with no errors.
  • buf breaking --against '.git#branch=origin/main' — passed with no breaking changes.
  • git diff --check — passed with no whitespace errors.

Test statistics: 3 passed / 0 failed / 0 skipped.
Linting passed with no errors.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2026

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 6, 2026, 1:42 AM

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contract follow-up looks good. The previous blocking issues are addressed: org scope is now present for member-group lookups, access grants surface provisioning state, repeated/map update fields have presence-aware replacement wrappers while preserving compatibility, and the runner identity request field-number gap is reserved. I also verified buf lint, buf breaking against origin/main, and git diff --check locally.

@vitramir vitramir merged commit ef1bc19 into main Jun 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix private networks API contract review issues

3 participants