Dependabot multi 9faa0f6d25 fix#1738
Conversation
Bumps [jquery](https://github.com/jquery/jquery) and [@types/jquery](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jquery). These dependencies needed to be updated together. Updates `jquery` from 3.5.0 to 4.0.0 - [Release notes](https://github.com/jquery/jquery/releases) - [Changelog](https://github.com/jquery/jquery/blob/main/changelog.md) - [Commits](jquery/jquery@3.5.0...4.0.0) Updates `@types/jquery` from 3.5.14 to 4.0.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jquery) --- updated-dependencies: - dependency-name: jquery dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/jquery" dependency-version: 4.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Geoffsc is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @Geoffsc, this is great progress!
I notice that the build is failing; I suspect that may be due to configuration changes needed in the regular webpack configuration (to parallel the changes in the dev server config). If you need help figuring that out, maybe we can pair on this after tomorrow's standup if time permits!
|
@demiankatz thank you, I believe it should be fixed now. All the tests are passing and |
|
Thanks, @Geoffsc, this does indeed look very promising! We'll probably want to test all of the extensions to be sure there aren't any gaps we're missing, but this is excellent progress. Maybe we can discuss at standup tomorrow what kind of testing we need in order to feel confident enough to merge this. |
2 participants
To fix the server not starting issue as a result of dependabot's jquery upgrade to 4.0.0:
jqueryaliasinwebpack-dev-server.jsto usepath.resolvejsviewsto the latest version which handles the removal of jQuery.isFunction