Conversation
Bumps [jquery](https://github.com/jquery/jquery) and [@types/jquery](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jquery). These dependencies needed to be updated together. Updates `jquery` from 3.5.0 to 4.0.0 - [Release notes](https://github.com/jquery/jquery/releases) - [Changelog](https://github.com/jquery/jquery/blob/main/changelog.md) - [Commits](jquery/jquery@3.5.0...4.0.0) Updates `@types/jquery` from 3.5.14 to 4.0.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jquery) --- updated-dependencies: - dependency-name: jquery dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/jquery" dependency-version: 4.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
demiankatz
left a comment
There was a problem hiding this comment.
This upgrade breaks the build, so clearly some deprecated functionality is in use somewhere. We'll need to do some work before this can be merged.
|
Hi! I pulled down the branch and the below is what I'm getting when I run
|
|
Thanks, @Geoffsc! I wonder if the package has renamed or reorganized its files, and we just need to adjust the Webpack configuration to pull jQuery from a slightly different place. If that's the case, I'd start by looking at the jQuery references in webpack.dev-server.js, double-checking the files present in the node_modules jquery directory, and adjusting to make things align correctly. If that helps, parallel changes will likely also be needed in the production-oriented webpack.config.js. |
|
Hi @demiankatz, from quick research I saw it's recommended to update the alias path using
This resolves the issue with the server not starting, however once it does start I get the following runtime error:
|
|
Sounds like maybe jsviews is not compatible with the new jQuery. I'm not sure if there's a newer jsviews version available than the one we're using that might fix this, or if this is an indication that we need to move away from using jsviews entirely. I'm not sure where/how extensively that is used, but it might be a good candidate for reviewing within the scope of the current component sprint. |
|
@demiankatz I upgraded Created PR #1738 to address! |
Bumps jquery and @types/jquery. These dependencies needed to be updated together.
Updates
jqueryfrom 3.5.0 to 4.0.0Release notes
Sourced from jquery's releases.
... (truncated)
Commits
4f2fae0Release: 4.0.0c838cfbRelease: remove dist files from main branch9752519Release: 4.0.0-rc.2c128d5dRelease: Update AUTHORS.txt5fe9c29Build: De-dupe three authors via mailmapafdd032Build: Post beta browser tests errors to jquery/dev on Matrix546a1ebBuild: Bump the github-actions group with 4 updatesec738b3Build: Fix Chrome beta testsc28c26aBuild: Add periodic tests on beta versions of browsersf513413Build: Bump the github-actions group with 2 updatesMaintainer changes
This version was pushed to npm by timmywil, a new releaser for jquery since your current version.
Updates
@types/jqueryfrom 3.5.14 to 4.0.0Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)