Fix TypeError when cheapest AirPricingSolution is not the first in the list

src/Services/Air/AirParser.js

@@ -201,7 +201,15 @@
   const prices = priceResult['air:AirPricingSolution'];
   const priceKeys = Object.keys(prices);
 
-  const pricing = prices[priceKeys[0]]['air:AirPricingInfo'];
+  const cheapestKey = priceKeys.length > 1
+    ? priceKeys.reduce((minKey, key) => (
+      parseFloat(prices[key].TotalPrice.slice(3)) < parseFloat(prices[minKey].TotalPrice.slice(3))
+        ? key
+        : minKey
+    ))
+    : priceKeys[0];
+
+  const pricing = prices[cheapestKey]['air:AirPricingInfo'];
 
   return Object.keys(pricing)
     .reduce((acc, right) => ({
@@ -381,6 +389,10 @@
 
     const pricingInfo = pricingInfos.find((info) => info.$.Key === reservationKey);
 
+    if (!pricingInfo) {
+      return;
+    }
+
     pricingInfo['air:PassengerType'].push({
       $: {
         BookingTravelerRef: 'P_' + index,
@@ -816,8 +828,8 @@
 
 function airCancelTicket(obj) {
   if (
     !obj['air:VoidResultInfo']
     || obj['air:VoidResultInfo'].ResultType !== 'Success'
   ) {
     throw new AirRuntimeError.TicketCancelResultUnknown(obj);
   }
@@ -925,8 +937,8 @@
     const providerInfoKey = providerInfo.Key;
     const resRemarks = remarks[providerInfoKey] || [];
     const splitBookings = (
       providerInfo['universal:ProviderReservationDetails']
       && providerInfo['universal:ProviderReservationDetails'].DivideDetails === 'true'
     )
       ? resRemarks.reduce(
         (acc, remark) => {

test/Air/AirParser.test.js

@@ -1162,6 +1162,45 @@
         test(jsonResult);
       }).catch((err) => assert(false, 'Error during parsing' + err.stack));
     });
+
+    it('should correctly select cheapest solution when it is not first', () => {
+      const passengers = [{
+        lastName: 'ENEKEN',
+        firstName: 'SKYWALKER',
+        passCountry: 'UA',
+        passNumber: 'ES221731',
+        birthDate: '19680725',
+        Age: 30,
+        gender: 'M',
+        ageCategory: 'ADT',
+      }];
+
+      const uParser = new Parser(null, 'v52_0', { passengers });
+      const parseFunction = airParser.AIR_PRICE_REQUEST_PRICING_SOLUTION_XML;
+      const xml = fs.readFileSync(`${xmlFolder}/AirPricingSolution.2AirPrice.cheapest-second.xml`).toString();
+      return uParser.parse(xml).then((json) => {
+        const jsonResult = parseFunction.call(uParser, json);
+        const airprice = jsonResult['air:AirPricingSolution'];
+        const airpricexml = jsonResult['air:AirPricingSolution_XML'];
+        assert(airprice, 'no air:AirPricingSolution');
+        assert(airpricexml, 'no xml object');
+        assert(airprice.TotalPrice, 'No total price');
+        assert(airprice.Key, 'No key');
+        assert(airprice.Taxes, 'No taxes');
+        assert(airpricexml['air:AirPricingInfo_XML'], 'no air:AirPricingInfo_XML');
+        assert(airpricexml['air:AirSegment_XML'], 'no air:AirSegment_XML');
+        // The cheapest solution (ou8oAxJKTlGiEXhqo3pIZA== with EUR178.88) should be selected,
+        // not the first one (FBdwwNHxRbC87v3+2SGmfQ== with EUR227.88).
+        assert.equal(airprice.TotalPrice, 'EUR178.88', 'Should select cheapest solution');
+        assert.equal(airprice.Key, 'ou8oAxJKTlGiEXhqo3pIZA==', 'Should use key of cheapest solution');
+        // Verify passenger type refs are present in the result XML and associated
+        // with the correct pricing info key from the cheapest solution.
+        const pricingInfoXml = airpricexml['air:AirPricingInfo_XML'];
+        assert(pricingInfoXml.indexOf('BookingTravelerRef') !== -1, 'BookingTravelerRef should be present');
+        // AirPricingInfo key of the cheapest solution should appear in the XML
+        assert(pricingInfoXml.indexOf('0cSmjfEaSVecrbEn/Ae8Eg==') !== -1, 'AirPricingInfo key of cheapest solution should be present');
+      }).catch((err) => assert(false, 'Error during parsing' + err.stack));
+    });
   });
 
   it('should test a request with hosttoken', () => {
@@ -1316,7 +1355,7 @@
 
             // Passengers
             pricingInfo.passengers.forEach(
               (p) => {
                 expect(p).to.be.an('object');
                 expect(p).to.include.all.keys(['uapi_passenger_ref', 'isTicketed']);
                 expect(p.uapi_passenger_ref).to.be.a('string');
@@ -1332,7 +1371,7 @@
 
             expect(pricingInfo.passengersCount).to.be.an('object');
             Object.keys(pricingInfo.passengersCount).forEach(
               (ptc) => expect(pricingInfo.passengersCount[ptc]).to.be.a('number')
             );
             expect(pricingInfo.taxesInfo).to.be.an('array');
             pricingInfo.taxesInfo.forEach(