Skip to content

Fix TypeError when cheapest AirPricingSolution is not the first in the list #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from

Fix TypeError when cheapest AirPricingSolution is not the first one

9541026
Select commit
Loading
Failed to load commit list.
Draft

Fix TypeError when cheapest AirPricingSolution is not the first in the list #680

Fix TypeError when cheapest AirPricingSolution is not the first one
9541026
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 12, 2026 in 40s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 1374 in test/Air/AirParser.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep. 

See more on https://sonarcloud.io/project/issues?id=Travelport-Ukraine_uapi-json&issues=AZzhalyu9JS2QyFtjpI-&open=AZzhalyu9JS2QyFtjpI-&pullRequest=680

Check warning on line 941 in src/Services/Air/AirParser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=Travelport-Ukraine_uapi-json&issues=AZzhal6q9JS2QyFtjpJD&open=AZzhal6q9JS2QyFtjpJD&pullRequest=680

Check warning on line 205 in src/Services/Air/AirParser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an initial value to this "reduce()" call. 

See more on https://sonarcloud.io/project/issues?id=Travelport-Ukraine_uapi-json&issues=AZzhal6q9JS2QyFtjpI_&open=AZzhal6q9JS2QyFtjpI_&pullRequest=680

Check warning on line 832 in src/Services/Air/AirParser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=Travelport-Ukraine_uapi-json&issues=AZzhal6q9JS2QyFtjpJC&open=AZzhal6q9JS2QyFtjpJC&pullRequest=680

Check warning on line 206 in src/Services/Air/AirParser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=Travelport-Ukraine_uapi-json&issues=AZzhal6q9JS2QyFtjpJA&open=AZzhal6q9JS2QyFtjpJA&pullRequest=680

Check warning on line 206 in src/Services/Air/AirParser.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=Travelport-Ukraine_uapi-json&issues=AZzhal6q9JS2QyFtjpJB&open=AZzhal6q9JS2QyFtjpJB&pullRequest=680

Check warning on line 1201 in test/Air/AirParser.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `.includes()`, rather than `.indexOf()`, when checking for existence. 

See more on https://sonarcloud.io/project/issues?id=Travelport-Ukraine_uapi-json&issues=AZzhalyu9JS2QyFtjpI8&open=AZzhalyu9JS2QyFtjpI8&pullRequest=680

Check warning on line 1199 in test/Air/AirParser.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `.includes()`, rather than `.indexOf()`, when checking for existence. 

See more on https://sonarcloud.io/project/issues?id=Travelport-Ukraine_uapi-json&issues=AZzhalyu9JS2QyFtjpI7&open=AZzhalyu9JS2QyFtjpI7&pullRequest=680

Check failure on line 1358 in test/Air/AirParser.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep. 

See more on https://sonarcloud.io/project/issues?id=Travelport-Ukraine_uapi-json&issues=AZzhalyu9JS2QyFtjpI9&open=AZzhalyu9JS2QyFtjpI9&pullRequest=680
View more details on SonarQubeCloud