Skip to content

switch to use read_azure_table_single_entity#419

Merged
tomjemmett merged 3 commits into
mainfrom
use_azkit_read_azure_table_single_entity
May 15, 2026
Merged

switch to use read_azure_table_single_entity#419
tomjemmett merged 3 commits into
mainfrom
use_azkit_read_azure_table_single_entity

Conversation

@tomjemmett

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 15, 2026 12:21
@tomjemmett
tomjemmett requested a review from a team as a code owner May 15, 2026 12:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors Azure Table Storage metadata retrieval to use a shared azkit::read_azure_table_single_entity() helper, and updates the package dependency to require a newer azkit version.

Changes:

  • Replaced the inline httr2 Azure Table entity request in get_model_run_from_ats() with azkit::read_azure_table_single_entity().
  • Added a minimum version requirement for azkit in DESCRIPTION.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
R/fct_get_data.R Switches Azure Table entity retrieval to azkit::read_azure_table_single_entity()
DESCRIPTION Requires azkit (>= 0.3.0) to support the new helper-based implementation
Comments suppressed due to low confidence (1)

R/fct_get_data.R:35

  • This call uses positional arguments, which makes it easy to accidentally swap table_name/partition_key/row_key/endpoint (and differs from the named-arg style used elsewhere in this file, e.g. azkit::get_container(...)). Prefer passing named arguments to read_azure_table_single_entity() for clarity and robustness.
  azkit::read_azure_table_single_entity(
    Sys.getenv("AZ_TABLE_NAME"),
    dataset,
    model_run_id,
    Sys.getenv("AZ_TABLE_EP"),

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/fct_get_data.R Outdated
Comment thread R/fct_get_data.R
Comment thread DESCRIPTION
tomjemmett and others added 2 commits May 15, 2026 13:41
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tomjemmett
tomjemmett merged commit 466a5a6 into main May 15, 2026
3 checks passed
@tomjemmett
tomjemmett deleted the use_azkit_read_azure_table_single_entity branch May 15, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants