switch to use read_azure_table_single_entity#419
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Azure Table Storage metadata retrieval to use a shared azkit::read_azure_table_single_entity() helper, and updates the package dependency to require a newer azkit version.
Changes:
- Replaced the inline
httr2Azure Table entity request inget_model_run_from_ats()withazkit::read_azure_table_single_entity(). - Added a minimum version requirement for
azkitinDESCRIPTION.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| R/fct_get_data.R | Switches Azure Table entity retrieval to azkit::read_azure_table_single_entity() |
| DESCRIPTION | Requires azkit (>= 0.3.0) to support the new helper-based implementation |
Comments suppressed due to low confidence (1)
R/fct_get_data.R:35
- This call uses positional arguments, which makes it easy to accidentally swap
table_name/partition_key/row_key/endpoint(and differs from the named-arg style used elsewhere in this file, e.g.azkit::get_container(...)). Prefer passing named arguments toread_azure_table_single_entity()for clarity and robustness.
azkit::read_azure_table_single_entity(
Sys.getenv("AZ_TABLE_NAME"),
dataset,
model_run_id,
Sys.getenv("AZ_TABLE_EP"),
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
matt-dray
approved these changes
May 15, 2026
StatsRhian
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.