fix(build): reclaim expired prometheus shared dict entries - #170
Merged
wklken merged 1 commit intoJul 24, 2026
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport the physical shared-dict reclamation fix from api7/nginx-lua-prometheus#18.
The existing cleanup removes only worker-local key-index references. Expired metric values and index slots can continue occupying shared-dict slab pages under label churn, causing
prometheus-metricsusage to grow without recovering. The build patch callsflush_expired()after the existing expiry scan.Related:
Verification
--fuzz=0against bothapache/apisix:3.16.0-redhatandapache/apisix:3.17.0-redhatbk-apigateway-apisix:prometheus-flush-master-codexfrom this branchself.dict:flush_expired()call inprometheus_keys.luaRUN_WITH_IT= make lint: 0 warnings / 0 errorsRUN_WITH_IT= make test: Busted 752 successes; test-nginx 681 tests, all successfulChecklist