fix(build): reclaim expired prometheus shared dict entries for release/1.23 - #171
Merged
wklken merged 1 commit intoJul 24, 2026
Conversation
(cherry picked from commit 7b4d193)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #170 to
release/1.23(APISIX 3.16.0).The build patch physically reclaims expired Prometheus metric values and key-index slots from
prometheus-metricsafter the existing expiry scan, preventing shared-dict slab usage from growing indefinitely under label churn.Source PR: #170
Upstream fix: api7/nginx-lua-prometheus#18
Related issue: apache/apisix#13658
Cherry-picked commits
7b4d193208bc4efa802584eddafacc5a11fef270fix(build): reclaim expired prometheus shared dict entriesVerification
--fuzz=0againstapache/apisix:3.16.0-redhatbk-apigateway-apisix:prometheus-flush-release-1.23-codexfrom this branchself.dict:flush_expired()call inprometheus_keys.luaRUN_WITH_IT= make lint: 0 warnings / 0 errorsRUN_WITH_IT= make test: Busted 752 successes; test-nginx 681 tests, all successfulChecklist