Skip to content

ACOMMONS-245 Exclude boolean casts from secret classification #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-teuchert-sonarsource merged 2 commits into from
Nov 9, 2026
Merged

ACOMMONS-245 Exclude boolean casts from secret classification #612

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c104095
Exclude boolean casts from secret classification
daniel-teuchert-sonarsource Nov 9, 2026
f53c8c7
Document CODESYS origin of boolean exclusions
daniel-teuchert-sonarsource Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion commons/src/main/java/org/sonarsource/analyzer/commons/appsec/SecretClassifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ Set<String> values() {
"p[@a]ssw[o0]rd",
// Boolean / null / scalar literals, e.g. "password = undefined", "enabled: true"
"^(?:none|undefined|null|true|false|yes|no|1|0)$",
"^\\(bool\\)(?:true|false)$",
// Starts with "your", e.g. "yourpassword", "your_super_secret"
"^your",
// Same character 4 times in a row, e.g. "abbbbc"
Expand Down Expand Up @@ -226,7 +227,7 @@ Set<String> values() {
// Leetspeak "password" variants with "@" that the "pass" substring misses
"p@ssword", "p@ssw0rd",
// Boolean / null / scalar literals
"undefined", "true", "null",
"undefined", "true", "null", "(bool)True", "(bool)False",
// "your..." prefix
"yourpassword",
// Same-character repetitions
Expand Down Expand Up @@ -316,6 +317,8 @@ Set<String> values() {
"Xk9Lm2Qp7Rs4Tv1Wz0",
"9f8e7d6c5b4a392817",
"Tr0ub4dor&3xpl0!t",
// Boolean casts are matched only as whole values
"prefix(bool)True", "(bool)FalseSuffix",
// Leading "__" without a closing "__"
"__not_closed",
// Credential words are matched only as whole values, so a value that merely contains one stays a candidate
Expand Down