Repository navigation
ACOMMONS-245 Exclude boolean casts from secret classification - #612
daniel-teuchert-sonarsource merged 2 commits into
Conversation
teemu-rytilahti-sonarsource
left a comment
There was a problem hiding this comment.
Thanks @daniel-teuchert-sonarsource!
Code Review ✅ Approved🟡 Medium risk · Excluding exact CODESYS boolean casts changes secret classification; a genuine value in that form could be omitted from hardcoded-secret findings. Excludes Verification Rules 2/2 met Repos 10 inspectedFunctional validation No results Rules 2 passed 1 not applicable
Broader impact Repos 10 inspectedCross-repo 10 repositories inspected 0 open impacts
5 more repositories Auto-approval Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|





Exclude
(bool)Trueand(bool)Falsefrom hardcoded-secret candidates using an anchored, case-insensitive pattern in the existing boolean literal group. Add both values to the shared validation corpus, plus prefix/suffix near-misses that must remain candidates.Validation: direct Java compilation and assertion checks passed for the shared positive/negative corpus, category classification, pattern coverage, and boolean case variants. Focused Maven tests could not run because required Sonar dependencies are not cached locally.
The commit hook flagged an unchanged synthetic credential in the existing sample corpus (
secrets:S8136); the hook was bypassed for this commit.