[Fix] Create a better log message when not connected to any peers.#3947
Merged
[Fix] Create a better log message when not connected to any peers.#3947
Conversation
kaimast
force-pushed
the
fix/sync-log-nopeers
branch
from
0d3af1c to
dfe67fb
Compare
kaimast
force-pushed
the
fix/sync-log-nopeers
branch
from
dfe67fb to
c8cb8a6
Compare
kaimast
commented
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simpler attempt at fixing #3885. The PR does not fix the issue of nodes starting as
synced, but I will leave that for another PR.The core change is that the sync state is never changed during block request generation, but only when processing responses, new block locators, or disconnects. For disconnects, there is a new function
SyncStatus::clear_greatest_peer_heightthat is used when a peer disconnects and no block locators are remaining.When invoking that function, the node's sync state will switch to
unsynceduntil it receives new block locators.The PR also adds more documentation to this delicate part of the codebase. Hopefully, the comments make the changes easy to review.