[Feature] Add unsynced status to block sync#3937
Closed
Conversation
Contributor
Author
|
Closing this because it was superseded by #3947. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3827.
The PR looks massive because the
PrimaryPingchanged to make the included certificate optional. This change is needed because now all nodes start as unsynced, and, as before, validators will not switch to synced without a primary ping and will not create certificates while not synced.Note: There are also some other changes in the PR that I still need to document. The PR also depends on #3936, and needs to be tested before merging.