Skip to content

Classify blocks by defaultState for runtime-state editions (Bedrock) #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pix3lPirat3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Classify blocks by defaultState for runtime-state editions (Bedrock) #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/movements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ class Movements {
this.fences = new Set()
this.carpets = new Set()
this.openable = new Set()
registry.blocksArray.map(x => Block.fromStateId(x.minStateId, 0)).forEach(block => {
// Java blocks carry a static minStateId; Bedrock uses runtime block-state palettes and exposes defaultState instead
// (minStateId is undefined), so fall back to it - otherwise fromStateId yields empty shapes and fences/carpets/
// emptyBlocks are never classified on Bedrock.
registry.blocksArray.map(x => Block.fromStateId(x.minStateId ?? x.defaultState, 0)).forEach(block => {
if (block.shapes.length > 0) {
// Fences or any block taller than 1, they will be considered as non-physical to avoid
// trying to walk on them
Expand Down
Loading