Skip to content

Update date_to cart_rule field to nullable #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicosomb wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update date_to cart_rule field to nullable #1671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions upgrade/sql/9.2.0.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
SET SESSION sql_mode='';
SET NAMES 'utf8mb4';

/* https://github.com/PrestaShop/PrestaShop/pull/40224 */
INSERT INTO `PREFIX_feature_flag` (`name`, `type`, `label_wording`, `label_domain`, `description_wording`, `description_domain`, `state`, `stability`) VALUES
('improved_b2b', 'env,dotenv,db', 'Improved B2B', 'Admin.Advparameters.Feature', 'Enable / Disable the improved B2B mode. To use the feature activate the B2B mode in General Settings', 'Admin.Advparameters.Help', 0, 'beta');
Expand Down Expand Up @@ -94,3 +97,6 @@
INDEX `b2b_role_authorization_role_role_idx` (`id_role`),
INDEX `b2b_role_authorization_role_auth_role_idx` (`id_authorization_role`)
) ENGINE=ENGINE_TYPE DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

/* Change date_to field to make it nullable in cart_rule, see https://github.com/PrestaShop/PrestaShop/pull/40867 */

Check warning on line 101 in upgrade/sql/9.2.0.sql

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

This single line comment should use the single line comment syntax "--" 


See more on https://sonarcloud.io/project/issues?id=PrestaShop_autoupgrade&issues=AZyO8lP2YCq9_CP_V6t7&open=AZyO8lP2YCq9_CP_V6t7&pullRequest=1671
ALTER TABLE `PREFIX_cart_rule` CHANGE `date_to` `date_to` datetime DEFAULT NULL;
Loading