Skip to content

Update date_to cart_rule field to nullable#1671

Open
nicosomb wants to merge 1 commit into
PrestaShop:devfrom
nicosomb:make-date-to-discount-nullable
Open

Update date_to cart_rule field to nullable#1671
nicosomb wants to merge 1 commit into
PrestaShop:devfrom
nicosomb:make-date-to-discount-nullable

Conversation

@nicosomb
Copy link
Copy Markdown
Contributor

Questions Answers
Description? Update date_to cart_rule field to nullable
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Sponsor company PrestaShop SA
How to test? Steps are here PrestaShop/PrestaShop#40801

Related to PrestaShop/PrestaShop#40867

boherm
boherm previously approved these changes Feb 24, 2026
@AureRita AureRita self-assigned this Feb 24, 2026
@AureRita
Copy link
Copy Markdown
Contributor

Hi @nicosomb

Thank you for your PR, as said on another PR of autoupgrade (#1666 (comment)) we can't currently update to unknown version. I'll adding blocked tag that we'll remove when the version 9.2.0 can be tested

Thank you

@AureRita AureRita removed their assignment Feb 24, 2026
@AureRita AureRita added the Blocked Status: The issue is blocked by another task label Feb 24, 2026
tleon
tleon previously approved these changes Mar 4, 2026
@jolelievre jolelievre closed this Mar 4, 2026
@github-project-automation github-project-automation Bot moved this from Ready for review to Closed in PR Dashboard Mar 4, 2026
@jolelievre jolelievre reopened this Mar 4, 2026
@github-project-automation github-project-automation Bot moved this from Closed to Reopened in PR Dashboard Mar 4, 2026
jolelievre
jolelievre previously approved these changes Mar 4, 2026
@Quetzacoalt91 Quetzacoalt91 added Waiting for rebase and removed Blocked Status: The issue is blocked by another task waiting for QA labels Mar 11, 2026
@Quetzacoalt91 Quetzacoalt91 added the new feature Type: New feature label Mar 18, 2026
@ga-devfront
Copy link
Copy Markdown
Contributor

@nicosomb coud you rebase please ?

@nicosomb nicosomb dismissed stale reviews from jolelievre, tleon, and boherm via 35b0d46 March 26, 2026 06:15
@nicosomb nicosomb force-pushed the make-date-to-discount-nullable branch from a53c688 to 35b0d46 Compare March 26, 2026 06:15
@sonarqubecloud
Copy link
Copy Markdown

@nicosomb
Copy link
Copy Markdown
Contributor Author

@ga-devfront done

@nicosomb nicosomb requested a review from tleon March 26, 2026 06:16
@nicosomb nicosomb requested review from boherm and jolelievre March 26, 2026 06:16
@Quetzacoalt91 Quetzacoalt91 removed the new feature Type: New feature label Apr 7, 2026
@M0rgan01
Copy link
Copy Markdown
Contributor

@nicosomb conflicts :s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Reopened

Development

Successfully merging this pull request may close these issues.

The expiration date must not be displayed when the “Period never expires” option is checked

9 participants