Skip to content

bug: fix malformed date in Bedrock AssumeRole session name #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lyqed wants to merge 1 commit into from
+2 −1
Closed

bug: fix malformed date in Bedrock AssumeRole session name #1728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/providers/bedrock/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,8 @@ export async function getAssumedRoleCredentials(
sha256: Sha256,
});
const date = new Date();
const sessionName = `${date.getFullYear()}${date.getMonth()}${date.getDay()}`;
// YYYYMMDD; RoleSessionName is visible in CloudTrail and the CUR's line-item identity
const sessionName = date.toISOString().slice(0, 10).replace(/-/g, '');
const url = `https://${hostname}?Action=AssumeRole&Version=2011-06-15&RoleArn=${awsRoleArn}&RoleSessionName=${sessionName}${awsExternalId ? `&ExternalId=${awsExternalId}` : ''}`;
const urlObj = new URL(url);
const requestHeaders = { host: hostname };
Expand Down