bug: fix malformed date in Bedrock AssumeRole session name#1728
Open
Lyqed wants to merge 1 commit into
Open
Conversation
getMonth() is zero-indexed and getDay() returns day-of-week, so the RoleSessionName came out as e.g. 202665 for 2026-07-10, and 202706 for 2027-01-02 (which reads as a mid-2027 date). Use the padded YYYYMMDD form instead. The session name is visible in CloudTrail and the CUR line-item identity, so the malformed value ends up in audit and billing data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: (required)
getAssumedRoleCredentialsbuilds the STSRoleSessionNamefrom${date.getFullYear()}${date.getMonth()}${date.getDay()}.getMonth()is zero-indexed andgetDay()returns the day of the week, not the day of the month, so the session name is a malformed date:202665on 2026-07-10, and202706on 2027-01-02, which reads as a mid-2027 date.YYYYMMDDform viadate.toISOString().slice(0, 10).replace(/-/g, '').${awsRoleArn}/${awsExternalId}/${awsRegion}), and the new value passes the STSRoleSessionNamecharset/length constraints ([\w+=,.@-]{2,64}).Tests Run/Test cases added: (required)
src/providers/bedrock/utils.ts; happy to add a test if you can point me at the preferred harness for provider utils.)Type of Change: