SelfLoader: try harder to not confuse PERLIO=stdio#24409
Open
tonycoz wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
The MSVC workflow failure seems likely to be caused by actions/runner-images#14004 |
ap
added
the
defer-next-dev
Contributor
|
The revert has been merged so this PR will need to include the original fix when it is applied, obviously. |
The previous change was failing on some FreeBSD and Linux, possibly because it assumed that a stdio level seek would result in an fd level seek, but a libc could optimize to just reposition within the buffer if the seeked to position has already been read in. So split this into two, first test that the handle is seekable without a net change in position, then only reposition the duplicated handle, which *should* have no buffered content.
tonycoz
force-pushed
the
selfloader-mixed-io-again
branch
from
0962d7a to
2294b1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous change was failing on some FreeBSD and Linux.
Fixes #24407
The two smokers that started failing are
freebsd 14.3-RELEASE-p8
FAIL in blead https://perl.develop-help.com/db/5530532
SUCCESS in branch https://perl.develop-help.com/db/5530604
linux 6.12.74+deb13+1-amd64 [Debian GNU/Linux 13.4 (trixie)]
FAIL in blead https://perl.develop-help.com/db/5530533
SUCCESS in branch https://perl.develop-help.com/db/5530606
The only other failures post 7a6d188 in blead or in the selfloader-mixed-io-again branch are:
https://perl.develop-help.com/db/5530547 - tib testing skiptest
https://perl.develop-help.com/db/5530603 - this smoker seems to be a bit flaky or here for a more comprehensive list
Edit: update perldev links now /similar is live, and perldev is down to discourage the bots