Skip to content

Revert "SelfLoader: don't mix buffered and unbuffered I/O"#24410

Merged
Leont merged 1 commit into
Perl:bleadfrom
tonycoz:24407-revert-selfloader
May 11, 2026
Merged

Revert "SelfLoader: don't mix buffered and unbuffered I/O"#24410
Leont merged 1 commit into
Perl:bleadfrom
tonycoz:24407-revert-selfloader

Conversation

@tonycoz
Copy link
Copy Markdown
Contributor

@tonycoz tonycoz commented May 7, 2026

This reverts commit 7a6d188.

This fixed some smoke failures but introduced others, go back to the old state.

Fixes #24407

An alternative to #24409


  • This set of changes does not require a perldelta entry.

This reverts commit 7a6d188.

This fixed some smoke failures but introduced others.

Fixes Perl#24407
@Leont
Copy link
Copy Markdown
Contributor

Leont commented May 7, 2026

On the short term, this is probably the best for 5.44.

On the longer term, we should seriously consider dumping :stdio, or at the very least downgrade it to no longer being a primary layer.

@tonycoz
Copy link
Copy Markdown
Contributor Author

tonycoz commented May 10, 2026

On the short term, this is probably the best for 5.44.

Is that a PSC instruction? (I have no problem doing it, I just don't want (more) churn at this point.)

On the longer term, we should seriously consider dumping :stdio, or at the very least downgrade it to no longer being a primary layer.

I think it's pretty secondary now, I expect the smoking is mostly inertia - I think it's the default, but that does reveal the occasional issue.

I doubt many are using PERLIO=stdio in production.

@Leont
Copy link
Copy Markdown
Contributor

Leont commented May 10, 2026

Is that a PSC instruction? (I have no problem doing it, I just don't want (more) churn at this point.)

No that's my personal opinion, we haven't discussed it yet (but probably will tomorrow).

@Leont Leont merged commit 62a1470 into Perl:blead May 11, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7a6d188450d generates new test failures on FreeBSD and Linux

2 participants