feat(ci): check board USB IDs against the Dronecode registry#27865
Open
mrpollo wants to merge 3 commits into
Open
feat(ci): check board USB IDs against the Dronecode registry#27865mrpollo wants to merge 3 commits into
mrpollo wants to merge 3 commits into
Conversation
Boards declaring the Dronecode USB VID (0x3643) must use a product ID registered to their manufacturer in https://github.com/Dronecode/usb-ids. CI checks only the defconfigs changed by a PR; other vendor IDs are ignored.
Contributor
💡 Commit messages could be improvedNot blocking, but these commit messages could use some cleanup.
See the commit message convention for details. This comment will be automatically removed once the issues are resolved. |
Keep the workflow file trivial; the changed-file detection and checker invocation live in a script named after the workflow, following the build_all_runner.sh convention.
Contributor
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 0 byte (0 %)]px4_fmu-v6x [Total VM Diff: -8 byte (-0 %)]Updated: 2026-07-10T19:58:49 |
Make the status check self-explanatory in the PR checks list so maintainers treat failures as registry violations, not routine lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dronecode owns USB VID
0x3643and assigns PIDs to member companies through the new Dronecode/usb-ids registry, which replaces the old spreadsheet. This PR wires that registry into CI so a board can't merge with an unregistered PID or one belonging to another manufacturer. We've already caught real cases of boards copying USB IDs from other vendors' defconfigs (most recently a PR shipping Auterion's VID with ZeroOne's PID), and today nothing stops that from landing.Tools/check_usb_ids.pyparses theCONFIG_CDCACM_*values from the given defconfigs and, for boards declaring VID0x3643, enforces three rules: the PID is registered, the board lives under the vendor directory registered to that manufacturer, andCONFIG_CDCACM_VENDORSTRis either the canonical "Dronecode Project, Inc." or the registered manufacturer name. Boards with other VIDs are ignored entirely. It also has alookupmode to resolve a PID or a board path to its owner.The workflow only triggers on
boards/**changes, checks just the defconfigs touched by the PR (fetched via the GitHub API, no toolchain, runs in seconds), and skips the Python steps when no defconfig changed. Verified locally against all in-tree defconfigs: the current tree passes clean (FMU-v6XRT and ZeroOne X6 are the two in-tree0x3643users), and unregistered PIDs, PIDs used from the wrong vendor directory, and wrong vendor strings each fail with a one-line error pointing at the offending defconfig.