feat(manual_control): Publish source of manual control setpoint via mavlink #27857
Open
RomanBapst wants to merge 3 commits into
Open
feat(manual_control): Publish source of manual control setpoint via mavlink #27857RomanBapst wants to merge 3 commits into
RomanBapst wants to merge 3 commits into
Conversation
- add translations for compatibility Signed-off-by: RomanBapst <bapstroman@gmail.com>
Signed-off-by: RomanBapst <bapstroman@gmail.com>
Signed-off-by: RomanBapst <bapstroman@gmail.com>
Contributor
💡 Commit messages could be improvedNot blocking, but these commit messages could use some cleanup.
See the commit message convention for details. This comment will be automatically removed once the issues are resolved. |
Contributor
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 88 byte (0 %)]px4_fmu-v6x [Total VM Diff: 96 byte (0 %)]Updated: 2026-07-10T08:04:05 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
When both RC input and manual control via a mavlink input device (such as Joystick) are available, it's not clear which device is currently used for manual control. PX4 implements COM_RC_IN_MODE parameters, which specifies input priorities, and the ManualControlSetpoint topic includes a source parameter, however this info is not published via mavlink and trying to figure out the source from the parameter value alone is not possible.
PX4 implements the MANUAL_CONTROL mavlink output stream, however, according to mavlink specs, this message is intended to be published by the controlling device, not the autopilot.
Therefore, I think it makes sense to add a new MANUAL_CONTROL_STATUS message, which captures the source of manual control.
Solution
Changelog Entry
For release notes:
Alternatives
Test coverage
Context
Mavlink PR: mavlink/mavlink#2540