fix(mavlink): accept NAV_TAKEOFF param1 on multicopters#27853
Merged
Conversation
Strict command-parameter validation added in PX4#27541 rejects MAV_CMD_NAV_TAKEOFF when an unsupported param is set. QGroundControl sends param1 (minimum pitch) = -1 on multicopter takeoff, which is non-zero/non-NaN, so commands were silently denied (MAV_RESULT_DENIED with no log) on MC airframes and QGC guided takeoff stopped working. Extend the NAV_TAKEOFF override to include VEHICLE_MC so param1 is accepted and ignored on multicopters, matching FW/VTOL handling.
Contributor
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: -16 byte (-0 %)]px4_fmu-v6x [Total VM Diff: -16 byte (-0 %)]Updated: 2026-07-09T18:09:58 |
Member
MaEtUgR
approved these changes
Jul 14, 2026
MaEtUgR
left a comment
Member
There was a problem hiding this comment.
Hotfix to have PX4 takeoff usable again with QGC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict command-parameter validation added in #27541 rejects MAV_CMD_NAV_TAKEOFF when an unsupported param is set. QGroundControl sends param1 (minimum pitch) = -1 on multicopter takeoff, which is non-zero/non-NaN, so commands were silently denied (MAV_RESULT_DENIED with no log) on MC airframes and QGC guided takeoff stopped working.
Extend the NAV_TAKEOFF override to include VEHICLE_MC so param1 is accepted and ignored on multicopters, matching FW/VTOL handling.