Repository navigation
Conversation
chibongho
approved these changes
Jul 21, 2026
chibongho
left a comment
chibongho
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Very minor suggestions.
| return; | ||
| } | ||
|
|
||
| var returnUrl = settings.data instanceof FormData ? (settings.data.get('returnUrl') || '') : ''; |
Collaborator
There was a problem hiding this comment.
Suggested change
| var returnUrl = settings.data instanceof FormData ? (settings.data.get('returnUrl') || '') : ''; | |
| const returnUrl = settings.data instanceof FormData ? (settings.data.get('returnUrl') || '') : ''; |
| // A "Save & Print" form (eg. a discharge disposition) carries printForm=true in its | ||
| // returnUrl. When present, the form will reload the visit page and auto-print, so tell | ||
| // the parent a print is pending and it should wait for it before closing the workspace. | ||
| var printPending = returnUrl.indexOf('printForm=true') !== -1 || returnUrl.indexOf('printForm%3Dtrue') !== -1; |
Collaborator
There was a problem hiding this comment.
Suggested change
| var printPending = returnUrl.indexOf('printForm=true') !== -1 || returnUrl.indexOf('printForm%3Dtrue') !== -1; | |
| const printPending = returnUrl.indexOf('printForm=true') !== -1 || returnUrl.indexOf('printForm%3Dtrue') !== -1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close the workspace after the form is printed
Screenshots
print_And_save.mov
Related Issue
https://openmrs.atlassian.net/browse/HTML-890
@chibongho , after @mogoodrich made this commit to the htmlformentryui, I was able to get this printing working from the ward app. Please see the recording above.
openmrs/openmrs-module-htmlformentryui@9d840b8
Thanks!