Repository navigation
Conversation
mogoodrich
approved these changes
Jul 21, 2026
chibongho
reviewed
Jul 21, 2026
| } | ||
| }; | ||
|
|
||
| var removeIframe = function() { |
Contributor
There was a problem hiding this comment.
Wouldn't this just close the iframe? Should we also trigger a message to close the workspace?
Member
Author
There was a problem hiding this comment.
@chibongho , the removeIframe function here in the visit.js closes the iFrame in which the printing template is loaded.
A couple lines above this code posts a 'o2IframeFormPrinted' message which the O3 O2VisitSummaryWorkspace component listens to and then it removes the patient from the ward and closes the workspace.
Contributor
There was a problem hiding this comment.
Oh, I didn't see that. Yeah, looks good then. Thanks!
chibongho
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mogoodrich and @chibongho , here are the corresponding changes in the pihcore to get this Print&Save button working.
I already have a PR in the esm-pihemr that shows how this works:
PIH/openmrs-esm-pihemr#40