Eliminate causes for AppleClang warnings - #446
Conversation
|
This PR has a strange history and conflicts. Could you rebase the actual fixes onto the newest devel branch? There are some CI run that should work as well. |
1. -Wunused-parameter: implementations in .hxx files that don't make use of the parameter names have the names removed. The proper names still exist in the .h file. 2. Explicit declaration of (unnecessary) copy constructor in OcTreeIterator implicitly deleted copy assignment. Deletion of explicit constructor allows the implict creation of both.
eee66c0 to
ae51dd7
Compare
|
Yeah. Sorry about that. I'd written it against Note: the original PR included a change in |
|
Thanks! With all the recent changes and rewrite of the CMake usage, the next release will probably be a "breaking" v2.0.0. Do you explicitly need these changes (+ other fixes) backported to a 1.10 bugfix release? |
|
I currently have mac CI build disabled (partly) due to things like this. A v1.10 bug fix would certainly help with that. (A smaller effort to resolve than may potentially be wrapped up in a major version change.) However, re-enabling that CI is currently a low priority for me. If there's enough interest in the community, I'd happily put it to use, but don't feel like you have to do it strictly for my needs. |
This cleans up a few inconsequential items that would otherwise trigger warnings (and errors if so promoted) in AppleClang.