Skip to content

Eliminate causes for AppleClang warnings - #446

Merged
ahornung merged 1 commit into
OctoMap:develfrom
SeanCurtis-TRI:PR_correct_warnings
Feb 8, 2026
Merged

Eliminate causes for AppleClang warnings#446
ahornung merged 1 commit into
OctoMap:develfrom
SeanCurtis-TRI:PR_correct_warnings

Conversation

@SeanCurtis-TRI

@SeanCurtis-TRI SeanCurtis-TRI commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

This cleans up a few inconsequential items that would otherwise trigger warnings (and errors if so promoted) in AppleClang.

  • Unused parmeters
  • Implicit deletion of copy assignment (by introduction of an unnecessary explicit copy constructor).

@ahornung

Copy link
Copy Markdown
Member

This PR has a strange history and conflicts. Could you rebase the actual fixes onto the newest devel branch? There are some CI run that should work as well.

1. -Wunused-parameter: implementations in .hxx files that don't make use
   of the parameter names have the names removed. The proper names still
   exist in the .h file.
2. Explicit declaration of (unnecessary) copy constructor in OcTreeIterator
   implicitly deleted copy assignment. Deletion of explicit constructor
   allows the implict creation of both.
@SeanCurtis-TRI

Copy link
Copy Markdown
Contributor Author

Yeah. Sorry about that. I'd written it against v1.10.0 and failed to rebase it against devel. I've now rebased it so things should be much cleaner.

Note: the original PR included a change in Vector::operator< that was missing in v1.10.0 but was in place in devel. So, a v1.10.1 would definitely benefit from the current state of devel even if this PR is rejected.

@ahornung
ahornung merged commit f012f5f into OctoMap:devel Feb 8, 2026
6 checks passed
@ahornung

ahornung commented Feb 8, 2026

Copy link
Copy Markdown
Member

Thanks! With all the recent changes and rewrite of the CMake usage, the next release will probably be a "breaking" v2.0.0. Do you explicitly need these changes (+ other fixes) backported to a 1.10 bugfix release?

@SeanCurtis-TRI

Copy link
Copy Markdown
Contributor Author

I currently have mac CI build disabled (partly) due to things like this. A v1.10 bug fix would certainly help with that. (A smaller effort to resolve than may potentially be wrapped up in a major version change.) However, re-enabling that CI is currently a low priority for me. If there's enough interest in the community, I'd happily put it to use, but don't feel like you have to do it strictly for my needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants