WIP: Equality constraint Jacobian test#38
Draft
PhilipFackler wants to merge 14 commits into
Draft
Conversation
* Fix line constraint bug in HiOp MDS module. --------- Co-authored-by: pelesh <pelesh@users.noreply.github.com>
…ns (#31) * test_acopf with PBPOLRAJAHIOPSPARSE (verify equality constraint Jacobian) + bug fix for PBPOL. Co-authored-by: William A Perkins <william.perkins@pnnl.gov> * Cleanup changes to RAJAHIOPSPARSE nnz computation. * Workaround for RAJAHIOPSPARSE inequality constraint verification. * Handling cases where IPOPT or HIOP are not available in test_acopt + bug fixes. * HiOp-compatible checks for constraint Jacobian allocations. Will need a smarter way to verify the stacked inequality constraints. * Fix for inequality constraint offsets. --------- Co-authored-by: William A Perkins <william.perkins@pnnl.gov> Co-authored-by: nkoukpaizan <nkoukpaizan@users.noreply.github.com>
PhilipFackler
force-pushed
the
PhilipFackler/cecj-test
branch
5 times, most recently
from
0231794 to
fef36fa
Compare
* Add more comments to HIOPRAJASPARSE implementation. * [skip ci] Add headers to the matpower file for Jacobian test. --------- Co-authored-by: pelesh <pelesh@users.noreply.github.com>
PhilipFackler
force-pushed
the
PhilipFackler/cecj-test
branch
from
fef36fa to
9aab0bb
Compare
* I am not going to lie, Cursor agent heavily helped me with this. Replace PETSc-based inequality Jacobian with GPU RAJA kernels Move the inequality constraint Jacobian computation for the HiOp sparse GPU solver entirely to the device, eliminating the per-iteration host back and forth (copy to host, PETSc compute, MatGetRow extraction, values copy back to device). Elimiate PETSc use from this part of the code. Three RAJA kernels now compute directly into device memory: - Generator set-point constraints (AGC) - Voltage-reactive-power bounds (FIXED_WITHIN_QBOUNDS) - Line flow limits (Sf^2/St^2 derivatives + slack variables) Supporting changes: - Analytical NNZ counting replaces PETSc MatGetInfo at solver setup - New device-side parameter fields (apf, vs, xpdevidx, xslackidx, bus-to-gen mapping) added to *ParamsRajaHiop structs - Sparse position indices assigned at model setup for all three contribution types Includes validation test (test_ineqjac_gpu) that solves with IPOPT, then compares PETSc and GPU Jacobian values at the converged solution. Optional -benchmark flag for performance comparison. Made-with: Cursor --------- Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com> Co-authored-by: pelesh <pelesh@users.noreply.github.com> Co-authored-by: Nicholson Koukpaizan <koukpaizannk@ornl.gov>
PhilipFackler
force-pushed
the
PhilipFackler/cecj-test
branch
from
9aab0bb to
cd1cb8e
Compare
PhilipFackler
force-pushed
the
PhilipFackler/cecj-test
branch
from
cd1cb8e to
e71c2d2
Compare
Collaborator
Author
20 tasks
nkoukpaizan
force-pushed
the
olcf-hackathon-2026-dev
branch
from
b332272 to
d023534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request type
Relates to
This MR updates
Summary
Summarize the MR concisely
Linked Issue(s)
Link any relevant issues. If merging into the default branch, any directly addressed issues will be closed when merging into the default branch (develop).
Since GitHub is specific on language, make sure to include direct language if you want to have the issue closed:
You can also reference issues, but this will not close the issue when the merge request is merged: