Cleanup hackathon unit tests#55
Merged
nkoukpaizan merged 15 commits intoMay 19, 2026
Merged
Conversation
pelesh
approved these changes
May 19, 2026
Collaborator
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
Thanks @nkoukpaizan for putting some order in ExaGO testing code! Looks good to me, but I would wait for @PhilipFackler's review before merging.
nkoukpaizan
added a commit
that referenced
this pull request
May 28, 2026
* Hessian --> hessian in unit test folders * ConstraintHessian --> ConstraintsHessian in hiopkernels. * UNIT_TEST_ --> UNIT_TESTS_. * Capitalize test names for consistency. * EQJAC --> EQUALITY_CONSTRAINT_JACOBIAN in test name. * Include OPFLOW_ in related objective and constraints Jacobian unit test names. * Cleanup a few CMake guards. * Reorganize opflow unit tests. * Remove option from test_ineqjac_gpu, i.e, always evaluate performance. * Minor edits to comments and print statements. * Fix test_eqjac NETFILES and remove unnecessary command line option. * Consolidate test_eqjac_gpu and test_eqjac_perf. * Minor comment/print statement fix. * Remove test_eqjac_perf from CMakeList. --------- Co-authored-by: nkoukpaizan <nkoukpaizan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request type
Relates to
This MR updates
Summary
This cleans up unit tests, particularly the constraints Jacobian tests/benchmarks added during the recent hackathon. This could always use more cleanup, but I think it moves us in the right direction.
test_pflow.cppfromtest/unit/totest/unit/pflowtest_acopf.cppandtest_ineqjac_gpu.cppfromtest/unit/totest/unit/opflowtest_eqjac_gpu.cppandtest_eqjac_perf.cppand moved them totest/unit/opflow. The intent is to keep the tests that are in subfolderconstraint_jacobianas true unit tests (comparing to "analytical" reference rather than PETSc, see WIP: Equality constraint Jacobian test #38)ConstraintHessian-->ConstraintsHessian)