Skip to content

Fix build and tests#200

Merged
kba merged 10 commits into
OCR-D:masterfrom
bertsky:fix-build
Mar 7, 2024
Merged

Fix build and tests#200
kba merged 10 commits into
OCR-D:masterfrom
bertsky:fix-build

Conversation

@bertsky

@bertsky bertsky commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

follow-up to #197 and #199

first step: show that CI currently fails

I had to add download=True anyway. It now succeeds.

@bertsky bertsky requested a review from kba February 22, 2024 11:11
@bertsky bertsky marked this pull request as ready for review February 22, 2024 12:06
@codecov

codecov Bot commented Feb 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (08a020f) to head (d5724ce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   52.43%   52.43%           
=======================================
  Files          12       12           
  Lines        1377     1377           
  Branches      335      335           
=======================================
  Hits          722      722           
  Misses        531      531           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikegerber

Copy link
Copy Markdown
Contributor

Fixed #202 for me, for a manual install of Tesseract (make install-tesseract from here)

@bertsky

bertsky commented Mar 6, 2024

Copy link
Copy Markdown
Collaborator Author

d5724ce was for sirfz/tesserocr#343 (which has now been merged, so we could even go to tesserocr:master).

@kba kba merged commit d5724ce into OCR-D:master Mar 7, 2024
kba added a commit to OCR-D/ocrd_all that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants