Delegate Tesseract build to ocrd_tesserocr#409
Merged
Conversation
added 6 commits
February 22, 2024 22:52
- remove rules and defs for Tesseract build
- delegate targets for ocrd_tesserocr executables (including Tesseract CLI)
to ocrd_tesserocr rules
- keep targets `{clean,install}-tesseract` and `install-tesseract-training`
(also delegating to ocrd_tesserocr rules), but decouple from `all`
- remove tesseract and tesserocr submodules
- ensure ocrd_tesserocr is checkout out recursively, too
Collaborator
Author
|
@kba do you have any idea why CI does not trigger on this PR? In CircleCI config, forked PR building is still enabled, but I cannot even see the PR... |
bertsky
force-pushed
the
delegate-tesseract-build
branch
from
670a6cf to
7f19746
Compare
…install Tesseract)
bertsky
force-pushed
the
delegate-tesseract-build
branch
from
7f19746 to
144b642
Compare
This was
linked to
issues
Mar 5, 2024
Closed
added 2 commits
March 5, 2024 21:54
Collaborator
Author
|
I don't know why it does not trigger the CI here, but at least it did on my fork. |
kba
approved these changes
Mar 7, 2024
joschrew
approved these changes
Mar 7, 2024
joschrew
left a comment
joschrew
left a comment
Contributor
There was a problem hiding this comment.
Thanks for notifying me. I have looked through the code and I am currently trying to test by building the Dockerimage. Probably it is not necessary to wait for me here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OCR-D/ocrd_tesserocr#200