[14.0][IMP] product_attribute_value_menu: merge module product_attribute_value_menu from V13#1132
Merged
OCA-git-bot merged 2 commits intoAug 30, 2022
Conversation
This was referenced Aug 12, 2022
GuillemCForgeFlow
suggested changes
Aug 12, 2022
JordiMForgeFlow
force-pushed
the
14.0-imp-product_attribute_value_menu
branch
from
5c748cc to
90538ac
Compare
francesco-ooops
approved these changes
Aug 22, 2022
Contributor
francesco-ooops
left a comment
francesco-ooops
left a comment
There was a problem hiding this comment.
@JordiMForgeFlow just a minor change, functional review ok! 👍
JordiMForgeFlow
force-pushed
the
14.0-imp-product_attribute_value_menu
branch
from
90538ac to
9f3cc31
Compare
JordiMForgeFlow
requested review from
GuillemCForgeFlow and
francesco-ooops
and removed request for
francesco-ooops
GuillemCForgeFlow
approved these changes
Aug 29, 2022
Contributor
GuillemCForgeFlow
left a comment
GuillemCForgeFlow
left a comment
There was a problem hiding this comment.
Functional review 👍
Contributor
|
@pedrobaeza could you check? fixes this issue |
Member
|
/ocabot merge major |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at d66bf9d. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed and agreed with the modules authors in #1079, due to two modules having the same name (one is in V13 and one is in V14) we are merging their features in the same module.