Skip to content

[15.0][MIG] product_attribute_value_menu#1128

Merged
OCA-git-bot merged 14 commits into
OCA:15.0from
ForgeFlow:15.0-mig-product_attribute_value_menu
Sep 2, 2022
Merged

[15.0][MIG] product_attribute_value_menu#1128
OCA-git-bot merged 14 commits into
OCA:15.0from
ForgeFlow:15.0-mig-product_attribute_value_menu

Conversation

@JasminSForgeFlow
Copy link
Copy Markdown
Contributor

@JasminSForgeFlow JasminSForgeFlow commented Jul 28, 2022

Standard Migration

@ForgeFlow

DavidJForgeFlow
DavidJForgeFlow approved these changes Jul 28, 2022
View reviewed changes
Copy link
Copy Markdown

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍 also code LGTM

JuanyDForgeflow
JuanyDForgeflow approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown

@JuanyDForgeflow JuanyDForgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AaronHForgeFlow
AaronHForgeFlow approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Aug 2, 2022

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiMForgeFlow
Copy link
Copy Markdown
Contributor

JordiMForgeFlow commented Aug 12, 2022

Hi @JasminSForgeFlow

Could you take into consideration also #1132? :)

@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-product_attribute_value_menu branch from f0d6a67 to 6452ed8 Compare August 22, 2022 06:23
@JasminSForgeFlow
Copy link
Copy Markdown
Contributor Author

JasminSForgeFlow commented Aug 22, 2022

Hi @JasminSForgeFlow

Could you take into consideration also #1132? :)

done, thanks

@JordiMForgeFlow
Copy link
Copy Markdown
Contributor

JordiMForgeFlow commented Aug 30, 2022

Hi @JasminSForgeFlow

Could you apply again the changes in #1132? small changes were added 4 days ago. The PR is now merged :)

ilyasProgrammer and others added 14 commits August 30, 2022 17:09
@ilyasProgrammer @JasminSForgeFlow
[14.0][REF] product_attribute_value_price_import: rename to product_a…
9c4ef19 
…ttribute_value_menu
@oca-travis @JasminSForgeFlow
[UPD] Update product_attribute_value_menu.pot
5769d7d
@OCA-git-bot @JasminSForgeFlow
[UPD] README.rst
d584d42
@OCA-git-bot @JasminSForgeFlow
[ADD] icon.png
658ff53
@francesco-ooops @JasminSForgeFlow
Added translation using Weblate (Italian)
0b951c7
@francesco-ooops @JasminSForgeFlow
Translated using Weblate (Italian)
459b904 
Currently translated at 100.0% (3 of 3 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_attribute_value_menu
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_attribute_value_menu/it/
@JordiMForgeFlow @JasminSForgeFlow
[IMP] product_attribute_value_menu: merge module product_attribute_va…
6a184a1 
…lue_menu from V13
@GuillemCForgeFlow @JasminSForgeFlow
[13.0][IMP]product_attribute_value_menu: Products related
c0671bd
@oca-travis @JasminSForgeFlow
[UPD] Update product_attribute_value_menu.pot
b167b32
@OCA-git-bot @JasminSForgeFlow
[UPD] README.rst
e262596
@OCA-git-bot @JasminSForgeFlow
product_attribute_value_menu 14.0.2.0.0
3b1b38a
@oca-transbot @JasminSForgeFlow
Update translation files
9e59c20 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-14.0/product-attribute-14.0-product_attribute_value_menu
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_attribute_value_menu/
@JasminSForgeFlow
[IMP] product_attribute_value_menu: black, isort, prettier
5767476
@JasminSForgeFlow
[MIG] product_attribute_value_menu: Migration to 15.0
709ca0f
@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-product_attribute_value_menu branch from 6452ed8 to 709ca0f Compare August 30, 2022 11:42
@JasminSForgeFlow
Copy link
Copy Markdown
Contributor Author

JasminSForgeFlow commented Aug 30, 2022

Hi @JasminSForgeFlow

Could you apply again the changes in #1132? small changes were added 4 days ago. The PR is now merged :)

Done, Thanks

@JordiBForgeFlow
Copy link
Copy Markdown
Member

JordiBForgeFlow commented Sep 2, 2022

/ocabot migration product_attribute_value_menu
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Sep 2, 2022
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Sep 2, 2022

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1128-by-JordiBForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Sep 2, 2022
Closed
65 tasks
@OCA-git-bot OCA-git-bot merged commit 82c089c into OCA:15.0 Sep 2, 2022
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Sep 2, 2022

Congratulations, your PR was merged at 0202bdb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@DavidJForgeFlow DavidJForgeFlow DavidJForgeFlow approved these changes

@JuanyDForgeflow JuanyDForgeflow JuanyDForgeflow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.