Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/test_feature_engineering.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,24 @@ def test_fourier_transform(setup_series):
)


@pytest.mark.parametrize("engine", ["pandas", "polars"])
def test_time_features_weekofyear(setup_series, engine):
# weekofyear is an alias of the ISO week
series, series_pl = setup_series
features = ["week", "weekofyear"]
if engine == "pandas":
transformed, future = time_features(series, freq="D", features=features, h=2)
else:
transformed, future = time_features(
series_pl, freq="1d", features=features, h=2
)
transformed, future = transformed.to_pandas(), future.to_pandas()
expected = transformed["ds"].dt.isocalendar().week.to_numpy()
np.testing.assert_array_equal(transformed["weekofyear"].to_numpy(), expected)
for df in (transformed, future):
pd.testing.assert_series_equal(df["weekofyear"], df["week"], check_names=False)


def is_weekend(times):
if isinstance(times, pd.Index):
dow = times.weekday + 1 # monday=0 in pandas and 1 in polars
Expand Down
4 changes: 3 additions & 1 deletion utilsforecast/feature_engineering.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,10 @@ def _compute_time_feature(
feat_name = feature.__name__
else:
feat_name = feature
if feature == "weekofyear":
feature = "week"
if isinstance(times, pd.DatetimeIndex):
if feature in ("week", "weekofyear"):
if feature == "week":
times = times.isocalendar()
feat_vals = getattr(times, feature).to_numpy()
else:
Expand Down
Loading