Repository navigation
fix: make the weekofyear alias work in time_features - #296
Merged
José Morales (jmoralez) merged 2 commits intoOct 9, 2026
Merged
Conversation
José Morales (jmoralez)
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
time_features(..., features=["weekofyear"])raisedAttributeErroron pandas, because the code callsisocalendar()for"week"and"weekofyear"and then looks the feature up by name, and the result only hasyear,weekandday. Polars failed as well since there is nodt.weekofyear. I mapweekofyeartoweekbefore the lookup, so both engines return the ISO week and the column keeps the name that was asked for. Added a test for pandas and polars that compares it withweek.