Skip to content

Replace hash groupby internals with HashCSR #24050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
PointKernel wants to merge 9 commits into
base: main
Choose a base branch
from
+1,998 −2,136
Draft

Replace hash groupby internals with HashCSR #24050

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b77c006
Replace hash groupby internals with HashCSR
PointKernel Sep 9, 2026
7d546ba
Store only row indices in the groupby HashCSR table
PointKernel Sep 9, 2026
67c719a
Fuse sum and sum of squares on the by-key groupby path
PointKernel Sep 9, 2026
8a906f2
Read HashCSR slots through L1 in the groupby build
PointKernel Sep 9, 2026
d64276f
Size the groupby HashCSR table from a sampled cardinality estimate
PointKernel Sep 9, 2026
346cc49
Pack small groups into the segmented reduce on the hash groupby path
PointKernel Sep 9, 2026
11d3dd1
Fuse the null mask into nullable hash groupby reductions
PointKernel Sep 9, 2026
ea84e5c
Fix HashCSR correctness and reduce grouping scratch memory
PointKernel Sep 10, 2026
a9a2b8b
Merge upstream main into hashcsr-groupby
PointKernel Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,14 +665,8 @@ add_library(
src/groupby/common/m2_var_std.cu
src/groupby/common/utils.cpp
src/groupby/groupby.cu
src/groupby/hash/compute_global_memory_aggs.cu
src/groupby/hash/compute_global_memory_aggs_null.cu
src/groupby/hash/compute_groupby.cu
src/groupby/hash/compute_mapping_indices.cu
src/groupby/hash/compute_mapping_indices_null.cu
src/groupby/hash/compute_shared_memory_aggs.cu
src/groupby/hash/compute_single_pass_aggs.cu
src/groupby/hash/compute_single_pass_aggs_null.cu
src/groupby/hash/extract_single_pass_aggs.cpp
src/groupby/hash/groupby.cu
src/groupby/hash/hash_compound_agg_finalizer.cu
Expand Down
22 changes: 0 additions & 22 deletions cpp/src/groupby/hash/compute_global_memory_aggs.cu
View file
Open in desktop

This file was deleted.

189 changes: 0 additions & 189 deletions cpp/src/groupby/hash/compute_global_memory_aggs.cuh
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions cpp/src/groupby/hash/compute_global_memory_aggs.hpp
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions cpp/src/groupby/hash/compute_global_memory_aggs_null.cu
View file
Open in desktop

This file was deleted.

Loading
Loading