Skip to content

Fix some miscellaneous clang-tidy errors #9999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jacobfaib wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −5
Open

Fix some miscellaneous clang-tidy errors #9999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5964c7d
Fix some miscellaneous clang-tidy errors
Jacobfaib Jul 17, 2026
8da74e0
fixup! Fix some miscellaneous clang-tidy errors
Jacobfaib Jul 17, 2026
e38f515
fixup! Fix some miscellaneous clang-tidy errors
Jacobfaib Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions libcudacxx/include/cuda/std/__algorithm/sort.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,12 @@ __bitset_partition(_RandomAccessIterator __first, _RandomAccessIterator __last,
}
else
{
while (++__first < __last && !__comp(__pivot, *__first))
while (++__first < __last)
{
if (__comp(__pivot, *__first))
{
break;
}
}
}
// Find the last element less than or equal to the pivot.
Expand Down Expand Up @@ -705,8 +709,14 @@ __partition_with_equals_on_right(_RandomAccessIterator __first, _RandomAccessIte
// Find the last element less than the pivot.
if (__begin == __first - difference_type(1))
{
while (__first < __last && !__comp(*--__last, __pivot))
;
while (__first < __last)
{
--__last;
if (__comp(*__last, __pivot))
{
break;
}
}
}
else
{
Expand Down Expand Up @@ -777,8 +787,12 @@ __partition_with_equals_on_left(_RandomAccessIterator __first, _RandomAccessIter
}
else
{
while (++__first < __last && !__comp(__pivot, *__first))
while (++__first < __last)
{
if (__comp(__pivot, *__first))
{
break;
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion libcudacxx/include/cuda/std/__random/linear_congruential_engine.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ class _CCCL_TYPE_VISIBILITY_DEFAULT linear_congruential_engine
private:
result_type __x_{};

static constexpr const result_type _Mp = result_type(~0);
static constexpr result_type _Mp = static_cast<result_type>(~0);

static_assert(__M == 0 || __A < __M, "linear_congruential_engine invalid parameters");
static_assert(__M == 0 || __C < __M, "linear_congruential_engine invalid parameters");
Expand Down
Loading