Fix some miscellaneous clang-tidy errors

[Jacobfaib]

Description

closes

Checklist

• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7d5ab5ae-280f-4f87-a19c-29c343047704

📥 Commits

Reviewing files that changed from the base of the PR and between 8da74e0 and e38f515.

📒 Files selected for processing (1)

• libcudacxx/include/cuda/std/__random/linear_congruential_engine.h

🚧 Files skipped from review as they are similar to previous changes (1)

• libcudacxx/include/cuda/std/__random/linear_congruential_engine.h

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved sorting behavior by adjusting pivot partitioning and “equals-on” partition handling to better manage iterator progression.
  • Updated the random engine’s internal constant initialization to align with standards-compatible casting behavior.

Walkthrough

Sort partition searches now use explicit comparator checks and loop breaks. The linear congruential engine’s internal _Mp declaration removes a redundant qualifier and uses static_cast.

Changes

Sort partition loops

Layer / File(s)	Summary
Partition search loop rewrites libcudacxx/include/cuda/std/__algorithm/sort.h	Three partition helper loops replace compound while predicates with explicit iterator updates, comparator checks, and break statements.

Random engine declaration

Layer / File(s)	Summary
Maximum-value constant declaration libcudacxx/include/cuda/std/__random/linear_congruential_engine.h	The internal _Mp declaration removes the extra const qualifier and changes initialization to static_cast<result_type>(~0).

Suggested reviewers: ericniebler

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 30d60885-515f-4613-bf4d-0021bc27c87c

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4a3bc and 8da74e0.

📒 Files selected for processing (2)

• libcudacxx/include/cuda/std/__algorithm/sort.h
• libcudacxx/include/cuda/std/__random/linear_congruential_engine.h

[github-actions]

🥳 CI Workflow Results

🟩 Finished in 1h 20m: Pass: 100%/120 | Total: 1d 02h | Max: 1h 10m | Hits: 95%/381914

See results here.