Fix installation command#1690
Closed
janEbert wants to merge 2 commits intoNVIDIA:masterfrom
Closed
Conversation
`--build-option` is not the correct config setting to use; we need `--global-option`. Ref NVIDIA#1679.
janEbert
force-pushed
the
readme-build-fix
branch
from
1b53a73 to
b34aedc
Compare
Author
|
Actually this command suffers from the same deprecation problems that the previous command tried to solve, see #1679 (comment). I assume the flags specified in |
This implements a custom build backend, inspired by [the solution used by Pillow](python-pillow/Pillow#7171). With this change, argument flags now need to be specified as key-value pairs instead of key-only as `--config-settings`. Every argument can either be left unspecified or have a value that is either "enabled" or "disabled". For example: ``` --config-settings --global-option=--cpp_ext --global-option --cpp_ext ``` becomes ``` --config-settings cpp_ext=enabled ``` The setuptools version requirement of 40.8.0 was also adopted from Pillow. It is the version that introduced the `build_meta:__legacy__` backend.
Author
|
See #1692. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--build-optionis not the correct config setting to use; we need--global-option.Ref #1679.