Update Apex build command#1689
Closed
janEbert wants to merge 1 commit intohuggingface:mainfrom
Closed
Conversation
Due to pip having deprecated `--global-option` and `--build-option`, this will be highly relevant in the future (removal is planned for 23.3, see pypa/pip#11859).
Contributor
|
CC @pacman100 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Author
|
Oops, I didn't even push the change I meant to this branch. :) |
Author
|
If NVIDIA/apex#1692 is accepted as the official solution, the current state will be fine to use. |
pacman100
approved these changes
Jul 12, 2023
Contributor
pacman100
left a comment
pacman100
left a comment
There was a problem hiding this comment.
Thank you for updating the docs, LGTM!
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to pip having deprecated
--global-optionand--build-option, the new build command will be highly relevant in the future (removal is planned for 23.3, see pypa/pip#11859).See also NVIDIA/apex#1690 for why the command is different from the Apex README.