Sync WW3 develop to dev/ufs-weather-model - #1618
Merged
JessicaMeixner-NOAA merged 16 commits intoSep 10, 2026
Merged
JessicaMeixner-NOAA merged 16 commits into
JessicaMeixner-NOAA merged 16 commits into
Conversation
…_JACOBI_GAUSS_SEIDEL_BLOCK to enable bit for bit reproducibility across different numbers of MPI processes. (NOAA-EMC#1538)
…ed for cases with switch PDLIB (NOAA-EMC#1588)
…tart reproducibility when variable water level is present and the domain has deep bathymetry. (NOAA-EMC#1589)
…evel and deep bathymetry. In subroutine W3ULEV KDCHK computed from bathymetric depth rather than total water level. (NOAA-EMC#1591)
…odels. (Developed by Jian-Guo Li) (NOAA-EMC#1602)
…ing the WCOR switch (NOAA-EMC#1603)
…ed operational switches in RWPS. Same switches are used in file model/bin/switch_NWS_rwps. (NOAA-EMC#1612)
… and build system updated. (NOAA-EMC#1605)
Collaborator
Author
|
UFSWM RT test Passed on Ursa. |
JessicaMeixner-NOAA
approved these changes
Aug 10, 2026
19 of 34 tasks
Co-authored-by: Christopher Stokes <christopher.stokes@metoffice.gov.uk>
…E=T. Resync eSum to post-restoration VA before the convergence check in PDLIB_JACOBI_GAUSS_SEIDEL_BLOCK. This fixes two related causes of the solver failing to exit early and running to JGS_MAXITER instead. (NOAA-EMC#1616)
…d all nml files so the output matches that of work_unstr_a.(NOAA-EMC#1619)
|
@mingchen-NOAA @JessicaMeixner-NOAA I see some failing CI on here--is that expected, or does something in this PR need fixing? |
Collaborator
Nothing is wrong with this PR. The CI hasn't been working in the develop branch for a while, but we have not had the time to attempt to see what is wrong and fix it. |
|
Testing on ufs-community/ufs-weather-model#3318 completed successfully. This PR can be merged. |
JessicaMeixner-NOAA
merged commit Sep 10, 2026
993de9b
into
NOAA-EMC:dev/ufs-weather-model
13 of 14 checks passed
4 of 32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR sync develop to dev/ufs-weather-model
Description
Routine sync of develop to dev/ufs-weather-model.
Including the following commits:
Three new regression test cases added:
Changes in regression test results:
Three new regression test cases added:
Change in regression test results:
ww3_tp2.17/./work_deep_restart (32 files differ)No change in regression test results.
Changes in regression test results:
No change in regression test result.
No change in regression test result.
Changes in regression test results:
Changes to
mod_defs.*andww3_grid*.outare expected as part of this PR. In addition,out_gridchanges for the following:results changes in:
Changes in regression test results:
Changes in regression test results:
Added a test case to ww3_ufs1.1 that includes the -N flag and adjusted all nml files so the output matches that of work_unstr_a.
One new regression test case is added:
ww3_ufs1.1/./work_unstr_a_nml (directory not found)No change in regression test result.
Fix additional compiler warnings and remarks.
No change in regression test result.
Issue(s) addressed
Commit Message
Sync develop as of 8-7-2026 to dev/ufs-weather-model
Check list
Testing
matrixCompFull.txt
matrixCompSummary.txt